fix: selection menu respect current node direction #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified insertNodeAfterSelection to copy current node text direction to the node which is going to get inserteded. resolves AppFlowy-IO#331
Codecov Report
@@ Coverage Diff @@
## main #360 +/- ##
==========================================
+ Coverage 75.97% 76.19% +0.21%
==========================================
Files 247 247
Lines 9866 9868 +2
==========================================
+ Hits 7496 7519 +23
+ Misses 2370 2349 -21
|
Merged
q200892907
added a commit
to q200892907/appflowy-editor
that referenced
this pull request
Aug 8, 2023
* main: chore: release 1.2.3 (AppFlowy-IO#362) chore: format code Solve the problem of screen appearing at critical positions when there is a URL in the link menu (AppFlowy-IO#346) fix: selection menu respects current node direction (AppFlowy-IO#360) fix: show selection menu at left (AppFlowy-IO#361) fix: selection reason should be ui event when clicking (AppFlowy-IO#359) fix: desktop color picker issue # Conflicts: # lib/src/editor/toolbar/desktop/items/link/link_toolbar_item.dart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modified insertNodeAfterSelection to copy current node text direction to the node which is going to get inserteded.
resolves #331